Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pem option to doc #3786

Merged
merged 6 commits into from
Sep 27, 2023
Merged

add pem option to doc #3786

merged 6 commits into from
Sep 27, 2023

Conversation

jschenz-chwy
Copy link
Contributor

@jschenz-chwy jschenz-chwy commented Jul 20, 2023 •
edited by dbeatty10
Loading

What are you changing in this pull request and why?

This change describes the option of using a plain-text PEM format private key for authentication with Snowflake added in dbt-labs/dbt-snowflake#671.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Checklist:

@jschenz-chwy jschenz-chwy requested a review from a team as a code owner July 20, 2023 17:48
@welcome
Copy link

welcome bot commented Jul 20, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@github-actions github-actions bot added new contributor Label for first-time contributors content Improvements or additions to content labels Jul 20, 2023
@netlify
Copy link

netlify bot commented Jul 20, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 05fb4f3
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64e74d82f065b3000810933a
😎 Deploy Preview https://deploy-preview-3786--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label Jul 20, 2023
This was referenced Jul 20, 2023
Closed
Merged
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Jul 20, 2023
Closed
1 task
@dbeatty10 dbeatty10 added the dbt-core v1.7 Docs impact for the v1.7 release (Oct 2023) label Jul 20, 2023
mirnawong1
mirnawong1 previously approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jschenz-chwy thanks for opening this pr up! Since this is for v1.7, we will go ahead and merge this for you then (3 months from now) ✨

@mirnawong1 mirnawong1 dismissed their stale review July 25, 2023 14:39

not ready for merge yet

@vercel
Copy link

vercel bot commented Sep 20, 2023

@runleonarun is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 4:20pm

@matthewshaver matthewshaver merged commit 5accefe into dbt-labs:current Sep 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

@mirnawong1 mirnawong1 mirnawong1 left review comments

Assignees
No one assigned
Labels
content Improvements or additions to content dbt-core v1.7 Docs impact for the v1.7 release (Oct 2023) new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
dbt Core v1.7 Documentation
Development

Successfully merging this pull request may close these issues.
5 participants
@jschenz-chwy @matthewshaver @mirnawong1 @dbeatty10 @runleonarun